[bobk]

RESOLVED:

In post 19611 above, Amin said to search for

$output = get_button_code_for_element($ret_product);

I searched for that string in my text editor (Coda) and got nothing.

Then I tried

$output = get_button_code_for_element

and that got me to the right place, which was line 215 in misc_functions.php.

If Amin’s post from last year is correct, then there was previously no ‘true’ after ‘($ret_product)’. Now there is. I replaced it with ‘false’, and that removed the line break.

Here’s what I think happened: Amin’s fix above worked when I tried it a few months ago, and during one of the recent updates, two things happened: 1) the update over-wrote the modification; and 2) the code changed so that the search he recommended didn’t work when I tried it before. It wasn’t till now that I thought of trying a modified search.

It would be nice if a detailed change log was posted with each update.

[bobk]

I re-read that post, but unless I’m missing something, it didn’t contain a solution for moving the ‘add to cart’ button.

Just to be clear, back then I was considering putting all those elements in a single row, but then I decided against it. I settled on having the price and the ‘format’ link (which is a Lightbox Ultimate link) above the variation menu, with the ‘add to cart’ button to the right. If I recall correctly, the method I successfully used for moving the add to cart button was in the following thread, or the one linked within it:

moving "add to cart" button on [wp_eStore:product_id:4:end]

Then, without my having changed anything (that I can recall), the ‘add to cart’ button got pushed down – I think it might have happened after an update to eStore (?).

In Firebug I found a line break after the variation menu, and when I deleted it (in Firebug), the ‘add to cart’ button moved back up where I wanted it.

So the question is ‘how do I get rid of that line break?’ Is it in the php code somewhere? Or am I missing something?

[bobk]

This didn’t work for me just now, nor did the solution posted here:

moving "add to cart" button on [wp_eStore:product_id:4:end]

I’m pretty sure I had it working before, and then an update to the plugin moved the button back down where I don’t want it. I went back in to eStore_misc_functions.php and restored these changes, but they had no effect. I also tried other CSS positioning, like

.eStore_add_to_cart_button {display: inline-block;}

The page under development is here: [http://tinyurl.com/bedmhwm]

I want the ‘add to cart’ button placed to the right of the drop-down menu, with their bottom edges aligned.

[bobk]

I get the part about creating a custom class for the anchor text – thanks.

I figured out a solution to remove the line breaks, but it’s different from the code you posted.

I removed the paragraph tags and tried the div as you described, but that didn’t change anything.

Instead of closing the div at the end of ‘Andrew Gilbert’, I closed it at the very end of the text following ‘critic’s pick’. That removed the line breaks.

Is there anything incorrect about what I did? It seems to have worked…

What I’m confused about is that you said that divs always start and end on a new line. If I understand correctly, the LU shortcode creates a div for the text link (right?), and that’s now enclosed in the other div I created. So why did the line break go away?

[bobk]

I’m having another line break problem.

This time it’s on this page: http://bobkarty.pairsite.com/press/

See the text link ‘Critic’s Pick’ a little more than half way down the page.

Lightbox Ultimate seems to be causing the following problems:

1. The line break between ‘Gilbert,’ and the link.

2. For the text link ‘Critic’s Pick’ and the text that follows, the font size is reduced from 14px to 13px and the font color is changed to black.

Also: does the plugin prohibit styling of the link text via the WP editor? I’d like to make the text link bold.

WordPress: 3.4.2

Lightbox Ultimate: 1.8.8

[bobk]

Good to know about the div class option. And yes, after posting my last message I realized that the sidebar and/or the mp3 player would need to be narrower to make room for everything side-by-side.

I appreciate your feedback about the design, and I agree! It’s fine as-is.

Thanks again for the help. Much appreciated.

Bob

Oakland, CA

[bobk]

Thanks for the reply, admin!

No you’re not missing anything – I’d made some changes by the time you saw the page.

To cover my bases, I’d also posted in the support forum for my [paid] WordPress theme, and someone provided the following solution to remove the colon (#2 above):

.eStore_variation_name {

display: none;

}

Is this OK? Is there any other way to get rid of it? And, most importantly to my curious mind, where is that coded in the plugin? I searched a bunch of the php files without success. It would also be good to know in case I want to use something other than the colon.

I’m glad to hear you think the page looks good! Still, I’d like to try putting the text ‘$1.00 Choose format (?)’ on the same line as the variation menu (question #1 above).

How can I do that?

Thanks again.

Bob

[bobk]

I’ll post this in the eStore forum, since it appears to involve that plugin…

[bobk]

Thanks for the clarification.

I get that Lightbox Ultimate is not causing the line break, but can you please help me understand what IS causing it?

The colon is in a ‘span’ element within the eStore-button-form:

<span class=”eStore_variation_name” > : </span>

The eStore-button-form already has a ‘display: inline’ attribute.

I don’t know how to proceed from here. Is there something I can do to get rid of that break?

[bobk]

I started with the first step – I deleted the ‘display: inline;’ attribute, per your suggestion.

Then I reloaded the page.

The result: There was ANOTHER line break – this one was after the word ‘format’.

In other words, now there were three lines of stuff below the topmost mp3 player:

1. The text ‘$1.00 Choose format’ on the first line.

2. The text ‘(?)’ on the second line.

3. The colon ( : ), the variation drop-down menu and the ‘add to cart’ button on the third line.

So… the ‘display: inline’ attribute was still working – it was preventing a line break BEFORE the Lightbox Ultimate text link.

The line break in question – AFTER the Lightbox Ultimate text link (i.e., between the text link and the colon) is a new, separate issue.

Now the question is ‘what’s causing this new line break?’ Since the colon is automatically inserted by Lightbox Ultimate, I’m still wondering if there’s something in the plugin that could be causing this.

I restored the ‘display: inline’ attribute, so now it’s back to just one unwanted line break.

Thoughts?

[bobk]

UPDATE:

When I updated WP eStore and Lightbox ultimate a few months ago, the unwanted line break reported in my initial post came back.

The CSS I added (as described on the previous page of this thread) resulted in the variation menu and ‘add to cart’ button being on the same line as the text ‘$1.00’ and ‘choose format’.

http://bobkarty.pairsite.com/listen_and_buy/leader_solo_artist/

The ‘display inline’ css is still present in the custom CSS of the child theme I’m using (‘Dynamik’, by Catalyst Theme), and I also tried adding it directly to the wp_lightbox_ultimate_custom.css file. That didn’t help.

How can I fix this?

Thanks in advance!

WordPress version: 3.4.2

WP eStore version: 6.9.4

Lightbox Ultimate version: 1.8.4

As best I can recall, I had not made any modifications to my site (i.e, the WordPress theme or the audio player plugin) when this issue returned.

[bobk]

I installed the update, and problem solved! Thank you!

I just purchased/downloaded LU yesterday, so I’m surprised I didn’t have the latest version. Or was the update released later in the day?

Also, FYI – your ‘Product Version Info Page’ needs updating. https://support.tipsandtricks-hq.com/version-info

Thanks again,

Bob

[bobk]

A web developer friend provided the solution; if I recall correctly, he said the plugin contains the anchor text in a div, which by default is displayed as a block element, and that caused the line break.

[bobk]

Resolved!

Added the following CSS to my child theme:

.lightbox_ultimate_text_anchor {

display: inline;

}

[bobk]

Sorry – I wasn’t entirely clear. The AAC variation will be sold at the basic price. That’s why I didn’t include a price for it in the variation code.

What’s the simplest way to add the basic price? I’m still trying to sort out the display options (both the standard and the ‘extra shortcodes’), and I’m getting a bit of ‘option overload’…

Thanks.

Bob

[Author]

Posts