Photo Seller – wrong toggle logic in wps-custom-admin.js

[DesMas]

Hi, the new setting feature for “Send Buyer Email As HTML” seems to have a not correctly working event-handler attached.

– checkbox-state: checked = wpps_buyer_email_body_row hidden

– checkbox-state: unchecked = wpps_buyer_email_body_row displayed

code to fix is in js/wps-custom-admin.js::10ff

Code:

//For email settings page section
$(‘#send_buyer_email_html’).on(‘click’, function(){
if (this.checked) {
$(“.wpps_buyer_email_body_row”).show(); //was hide()
} else {
$(“.wpps_buyer_email_body_row”).hide(); //was show()
}
});

[Peter]

Thank you for the feedback.

I will investigate further.

[Peter]

Hi again,

I checked out the code and actually the current behaviour is correct.

When you check “Send Buyer Email As HTML” it is meant to hide the “Buyer Email Body” section because the plugin will send a predefined tabularised HTML version of the buyer email. (similar to the receipt page)

This HTML layout cannot at this stage be modified but that may change in future.

If you leave the “Send Buyer Email As HTML” unchecked you will see the “Buyer Email Body” section which will be sent as plain text format.

[DesMas]

OK.

Than there was a misunderstanding.

Maybe the check-box should be named something like “send customized Buyer Email”.

I believe people mostly think “the positive way” when setting a check-box to checked state

[Author]

Posts